Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Use correct types and formatters for call overrides #2843

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Feb 23, 2023

What was wrong?

closes #2832

How was it fixed?

  • Fix typing for CallOverrideParams based on the expected types.
  • Use proper formatters for call override params
  • Add testing

Todo:

Cute Animal Picture

20230223_131751 (1)

@fselmo fselmo force-pushed the bugfix-eth-call-overrides-formatters branch 2 times, most recently from ad17299 to 90fa8be Compare February 23, 2023 20:07
@fselmo fselmo force-pushed the bugfix-eth-call-overrides-formatters branch from 90fa8be to 348d6ec Compare February 23, 2023 20:14
@fselmo fselmo marked this pull request as ready for review February 23, 2023 20:20
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 !

@fselmo fselmo merged commit b0d951a into ethereum:master Feb 23, 2023
@fselmo fselmo deleted the bugfix-eth-call-overrides-formatters branch February 23, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot unmarshal non-string into Go struct field OverrideAccount.balance of type *hexutil.Big
2 participants