Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken version selector in docs #2883

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Mar 16, 2023

What was wrong?

Since v6 released, the version selector at the bottom of readthedocs hasn't worked

How was it fixed?

sphinx_rtd_theme listed jquery not loading as a known issue. Applied their fix.

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the fix-docs-version-selector branch 6 times, most recently from 8655203 to f340c52 Compare March 20, 2023 16:49
@pacrob pacrob requested a review from kclowes March 20, 2023 20:55
@pacrob pacrob requested a review from fselmo March 21, 2023 14:43
@fselmo
Copy link
Collaborator

fselmo commented Mar 21, 2023

@pacrob what's the best way to test this? I'm not sure that the readthedocs builds from PR # ever had the issue. I'm seeing it working with some PRs that are currently open.

@pacrob
Copy link
Contributor Author

pacrob commented Mar 21, 2023

@pacrob what's the best way to test this? I'm not sure that the readthedocs builds from PR # ever had the issue. I'm seeing it working with some PRs that are currently open.

Not sure about testing, short of some kind of webpage testing. Docs for 2882, 2886, and 2887 come up with it not working for me, where 2883 weren't working yesterday, then started working when I made the change to conf.py.

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are also not working for me but 2857 and 2861 are. It would be nice to have some other way to test this but I'm inclined to merge it in and see what happens since it wouldn't hurt anything and looks to be the proposed solution, as you linked above.

I'd say let's give it a shot and retract the newsfragment if it doesn't fix the jquery injection and go from there.

@pacrob pacrob merged commit 51ead81 into ethereum:master Mar 21, 2023
@pacrob pacrob deleted the fix-docs-version-selector branch April 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants