Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geth fixture to use geth v1.11.5 #2896

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Mar 27, 2023

Update go-ethereum integration test suite to use the latest version - v1.11.5

Extra:

  • Add the go-ethereum version and the py-geth version as pipeline parameters for CircleCI builds for ease of configuration. Updated contributing docs to better reflect all changes necessary for updating the geth test fixture.

Todo:

Cute Animal Picture

20230327_123925

@fselmo fselmo force-pushed the update-geth-fixture-to-v1.11.5 branch 3 times, most recently from 41ec1e4 to 3d653b9 Compare March 27, 2023 22:39
@fselmo fselmo force-pushed the update-geth-fixture-to-v1.11.5 branch 3 times, most recently from 3802490 to ea73f52 Compare March 27, 2023 22:59
@fselmo fselmo requested a review from pacrob March 27, 2023 23:05
@fselmo fselmo marked this pull request as ready for review March 27, 2023 23:06
- Create pipeline parameters for the ``go-ethereum`` version and the ``py-geth`` version for CI builds to more easily manage updates and generate less noise when updating the test fixtures.
- Update contributing docs to reflect all changes required when updating the integration test fixtures.
@fselmo fselmo force-pushed the update-geth-fixture-to-v1.11.5 branch from ea73f52 to 89a534a Compare March 27, 2023 23:08
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing cleanup, nicely done. lgtm.

@fselmo fselmo merged commit 7592e98 into ethereum:master Mar 28, 2023
@fselmo fselmo deleted the update-geth-fixture-to-v1.11.5 branch March 28, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants