Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build to towncrier commands #2915

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 12, 2023

What was wrong?

The towncrier version dependency got updated which included a change in their commands. Needed to update throughout the Makefile.

How was it fixed?

Added build to towncrier commands.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review April 12, 2023 20:00
@kclowes kclowes requested review from fselmo and pacrob April 12, 2023 20:13
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 1a11562 into ethereum:master Apr 12, 2023
@kclowes kclowes deleted the towncrier-build branch April 12, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants