Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how we run tox for win CI builds #2923

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 18, 2023

What was wrong?

Windows builds are finally working when referencing tox via python -m tox -r. Hopefully the headaches with changing PACKER names goes away for good now. Thanks to @pacrob for trying it again.

How was it fixed?

Todo:

Cute Animal Picture

20230402_124811_2

@fselmo fselmo force-pushed the update-win-orb-path branch 4 times, most recently from 3359303 to b31d5fa Compare April 18, 2023 16:49
@fselmo fselmo marked this pull request as ready for review April 18, 2023 17:10
@fselmo fselmo requested a review from pacrob April 18, 2023 17:23
@fselmo fselmo changed the title Update the win CI path to tox.exe to be more flexible Update how we run tox for win CI builds Apr 18, 2023
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 824ba41 into ethereum:master Apr 18, 2023
@fselmo fselmo deleted the update-win-orb-path branch April 18, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants