Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-compile test contracts with Solidity v0.8.20 #2951

Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented May 10, 2023

What was wrong?

closes #2950

How was it fixed?

  • Re-compiled test contracts with new Solidity version v0.8.20
  • Re-generate integration test fixture deploying the updated test contracts bytecode

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the recompile-contracts-with-solidity-v0.8.20 branch from 52ad1fc to 4729a3b Compare May 12, 2023 21:10
@fselmo fselmo marked this pull request as ready for review May 12, 2023 21:24
@fselmo fselmo force-pushed the recompile-contracts-with-solidity-v0.8.20 branch from 4729a3b to 4aefbd5 Compare May 12, 2023 21:25
@fselmo fselmo requested review from kclowes and pacrob May 12, 2023 21:28
- test contracts were compiled using Solidty ``0.8.20``, re-generate the fixture to deploy the updated bytecode for the test contracts to run against the integration test suite
@fselmo fselmo force-pushed the recompile-contracts-with-solidity-v0.8.20 branch from e8bb637 to d79a84d Compare May 14, 2023 00:06
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fselmo fselmo merged commit 32bfc0d into ethereum:main May 15, 2023
@fselmo fselmo deleted the recompile-contracts-with-solidity-v0.8.20 branch May 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recompile test contracts with new Solidity version: v0.8.20
3 participants