move ethpm deprecation warning to only show when enabled #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
ethpm-dep-warning-only-on-enable
branch
from
e8b3069
to
18c8daa
Compare
fselmo
reviewed
Jun 6, 2023
pacrob
force-pushed
the
ethpm-dep-warning-only-on-enable
branch
2 times, most recently
from
b6784bf
to
e01d7b4
Compare
pacrob
force-pushed
the
ethpm-dep-warning-only-on-enable
branch
from
e01d7b4
to
bb5108f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
ethpmdeprecation warning was showing up too much.How was it fixed?
Moved it to only warn when enabling with
enable_unstable_package_management_apiTodo:
Cute Animal Picture