Clean up test warnings #2991
Merged
Clean up test warnings #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
cleanup-test-warnings
branch
from
661cf4c
to
dcc27a9
Compare
kclowes
force-pushed
the
cleanup-test-warnings
branch
4 times, most recently
from
ea2e23c
to
3ccd376
Compare
kclowes
force-pushed
the
cleanup-test-warnings
branch
from
3ccd376
to
7a2c8fc
Compare
fselmo
reviewed
Jun 20, 2023
tests/core/utilities/test_request.py
Outdated
| async_cache_and_return_session(endpoint_uri) | ||
| ) | ||
| try: | ||
| event_loop = asyncio.new_event_loop() |
There was a problem hiding this comment.
How is the event_loop defined here if the try fails?
There was a problem hiding this comment.
Nice catch. Removed the try and no more warnings were issued.
pacrob
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There were a bunch of warnings being emitted in various tests.
How was it fixed?
Cleaned up some, mostly by closing loops and sessions.
Limiting
requeststo <=2.29.0 will get rid of the DeprecationWarning:/home/circleci/repo/.tox/py310-core/lib/python3.10/site-packages/urllib3/poolmanager.py:315: DeprecationWarning: The 'strict' parameter is no longer needed on Python 3+. This will raise an error in urllib3 v2.1.0., but I opted not to do that. I think they'll clean it up eventually.The warnings from
tests/core/tools/pytest_ethereum/test_deployer.py::test_user_code_with_fixtureare due to this file, and specifically thew3andstart_websocket_serverfixtures.Todo:
Cute Animal Picture