Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async_http_retry_request_middleware, add tests for async_http_ret… #3009

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

LaoGunz
Copy link

@LaoGunz LaoGunz commented Jun 24, 2023

there was no method for http_retry_request_middleware for AsyncWeb3

What was wrong?
closes #3003

How was it fixed?
add async_http_retry_request_middleware, add tests for async_http_ret…

Todo:

  • Document async_http_retry_request_middleware
  • Add relevant newsfragments

@fselmo
Copy link
Collaborator

fselmo commented Jul 5, 2023

This looks great @LaoGunz. I'm going to add relevant newsfragments and docs and merge. Thanks for submitting 👍🏼

fselmo added a commit to LaoGunz/web3.py that referenced this pull request Jul 5, 2023
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@fselmo fselmo force-pushed the async_http_retry_request_middleware branch from 1171180 to 7127498 Compare July 5, 2023 21:53
@fselmo fselmo merged commit db7e344 into ethereum:main Jul 5, 2023
1 check passed
fselmo added a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async_http_retry_request_middleware
4 participants