Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthereumTesterProvider support for get storage at #3011

Merged
merged 6 commits into from
Jun 29, 2023
Merged

EthereumTesterProvider support for get storage at #3011

merged 6 commits into from
Jun 29, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Jun 28, 2023 •
edited
Loading

What was wrong?

  • eth_getStorageAt is supported in the latest eth-tester. Turn on support for it in web3.py via EthereumTesterProvider.

How was it fixed?

  • Bump eth-tester version to latest - v0.9.0-beta.2
  • Turn on support for eth_getStorageAt for EthereumTesterProvider
  • Add tests
    • Create a StorageContract.sol with actual values at storage slots and update all eth_getStorageAt tests to use this contract and check against the values received + formatted via the API
    • Turn on these tests for EthereumTesterProvider, assert behaves exactly as geth does by passing the same tests

Note - expected test failures for now:

This has been tested locally but the eth-tester version will need to be updated after it is released so that the CI runs can install that version and pass the integration-ethtester-pyevm tests. [updated]

Todo:

Cute Animal Picture

20230629_105452

@fselmo fselmo changed the title Eth tester support for get storage at EthereumTesterProvider support for get storage at Jun 28, 2023
@fselmo fselmo marked this pull request as ready for review June 29, 2023 16:47
@fselmo fselmo requested review from pacrob and reedsa June 29, 2023 17:04
pacrob
pacrob approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice drying in test_ethereum_tester

@fselmo fselmo merged commit 02e426a into ethereum:main Jun 29, 2023
@fselmo fselmo deleted the eth-tester-support-for-get-storage-at branch June 29, 2023 20:41
@fselmo fselmo mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@reedsa reedsa Awaiting requested review from reedsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fselmo @pacrob