Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed improper method call in datastructures.py #3080

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

fazledyn-or
Copy link
Contributor

What was wrong?

In Python, NotImplementedError exception should be raised by abstract classes/methods when they require the derived classes to override the method. And NotImplemented is a constant which should be returned by "special binary methods" such as- __add__, __eq__, __lt__, etc. to indicate that the operation is not implemented with respect to other type.

Since NamedElementOnion isn't derived from any classes, it's recommended and considered a good practice to use NotImplemented instead of NotImplementedError. Here's an example of how to implement binary operations for complex classes.

You can find more references here:

How was it fixed?

It was fixed by just replacing NotImplementedError exception with the constant NotImplemented


CLA Requirements:

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed - to improve global software supply chain security.

The bug is found by running the iCR tool by OpenRefactory, Inc. and then manually triaging the results.

web3/datastructures.py Outdated Show resolved Hide resolved
@fselmo fselmo merged commit f47889d into ethereum:main Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants