Add formatter for data field for transaction results
#3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
data-formatters-for-txns
branch
from
1b16846
to
5db56d5
Compare
fselmo
force-pushed
the
data-formatters-for-txns
branch
from
5db56d5
to
ecfb414
Compare
- Nethermind returns both ``data`` and ``input`` with the same value for each. Add a formatter for ``data`` that will format the field if it is present. - Add a test for transaction result formatters via ``eth.get_transaction()`` test.
fselmo
force-pushed
the
data-formatters-for-txns
branch
from
ecfb414
to
26e221a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
dataandinputwith the same value for each. Add a formatter fordatathat will format the field if it is present.eth.get_transaction()test.Todo:
Cute Animal Picture