Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong test reference to super class #3171

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix wrong test reference to super class #3171

merged 1 commit into from
Dec 15, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Dec 15, 2023 •
edited
Loading

What was wrong?

  • Wrong super class test reference and expected exception class

How was it fixed?

  • Fixed the reference and expected exception class

Todo:

Cute Animal Picture

20231214_114635

@fselmo fselmo marked this pull request as ready for review December 15, 2023 20:51
@fselmo
Fix wrong test reference to super class
aea41aa 
- eth-tester integration tests has a wrong reference to the call_override test for eth-tester
kclowes
kclowes approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tests/integration/test_ethereum_tester.py
@@ -315,8 +315,8 @@ class TestEthereumTesterEthModule(EthModuleTest):
EthModuleTest.test_eth_replace_transaction_already_mined, MethodUnavailable
)
test_eth_call_with_override_param_type_check = not_implemented(
EthModuleTest.test_eth_max_priority_fee_with_fee_history_calculation,
ValueError,
EthModuleTest.test_eth_call_with_override_param_type_check,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, nice catch!

@fselmo fselmo merged commit 553dee4 into ethereum:main Dec 15, 2023
99 checks passed
@fselmo fselmo deleted the fix-wrong-test-reference branch December 15, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

@kclowes kclowes kclowes approved these changes

@pacrob pacrob Awaiting requested review from pacrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fselmo @reedsa @kclowes