geth --dev test fixture setup
#3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
messy-geth-dev-test-setup
branch
6 times, most recently
from
367bef4
to
aa78a85
Compare
reedsa
reviewed
Jan 19, 2024
reedsa
reviewed
Jan 19, 2024
fselmo
force-pushed
the
messy-geth-dev-test-setup
branch
from
aa78a85
to
62d3ee3
Compare
reedsa
reviewed
Jan 19, 2024
reedsa
force-pushed
the
messy-geth-dev-test-setup
branch
from
9e13268
to
244348c
Compare
reedsa
reviewed
Jan 23, 2024
fselmo
force-pushed
the
messy-geth-dev-test-setup
branch
from
66fea31
to
5192fb3
Compare
reedsa
force-pushed
the
messy-geth-dev-test-setup
branch
from
3af4c15
to
e10a736
Compare
fselmo
force-pushed
the
messy-geth-dev-test-setup
branch
2 times, most recently
from
6e906f8
to
fd4eab0
Compare
|
^^ squashed and rebased |
reedsa
force-pushed
the
messy-geth-dev-test-setup
branch
3 times, most recently
from
cbba343
to
abcce6d
Compare
fselmo
force-pushed
the
messy-geth-dev-test-setup
branch
from
abcce6d
to
21dc730
Compare
reedsa
force-pushed
the
messy-geth-dev-test-setup
branch
from
21dc730
to
56d7426
Compare
pacrob
reviewed
Jan 26, 2024
pacrob
reviewed
Jan 26, 2024
pacrob
reviewed
Jan 26, 2024
tests/integration/go_ethereum/test_goethereum_ws_v2/conftest.py
Outdated
Show resolved
Hide resolved
pacrob
approved these changes
Jan 26, 2024
…ing: - Quicker timeout for unmined wait-for-txn-receipt tests - Update default fees test for geth --dev mode - Get rid of all miner start() and stop() references - Run integration tests with --dev flag - Test refactoring for ``geth --dev`` test fixture setup - Remove PoW related endpoint tests; TODO: remove / deprecate endpoints - Support latest geth versions - Update geth version in circleCI config + peripherally related changes - Turn on PoS block identifier tests - get geth --dev test suite working
- Flaky for replace transaction - Fix typing - Loosen assertions on gas - Nonce value fix - Loosen asserts for default maxFeePerGas and maxPriorityFeePerGas tests
- Add @flaky to tests that expect mining at certain times - This isn't ideal. Perhaps we can increase the ``dev.period`` (mining interval) to make these tests a bit more reliable and hopefully the other tests are unaffected. - Update benchmark to run with ``geth --dev`` setup - Put back old state of get_logs_without_logs for eth_tester
- Try with --dev.period=5 - Remove assert from test_eth_new_block_filter - Remove sleep from test_web3_client_version - Try without flaky - Fixes test_eth_send_transaction_with_nonce without the need for retries. - Retries were causing transactions to be sent with the same nonce, which in turn requires more gas to go through. Running the test once fixes this issue. - Obtain the transaction count providing the 'pending' argument. - Fix test_eth_send_transaction_no_max_fee
reedsa
force-pushed
the
messy-geth-dev-test-setup
branch
from
56d7426
to
bb312ee
Compare
fselmo
commented
Jan 26, 2024
| @@ -49,6 +52,14 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| """ | |||
reedsa
force-pushed
the
messy-geth-dev-test-setup
branch
from
7b85d6d
to
6191d09
Compare
|
lgtm but I can't review it since it's my branch 😆... green light from me though 👍🏼 |
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Jan 26, 2024
reedsa
added a commit
that referenced
this pull request
Jan 30, 2024
* WIP: Generate geth fixture for shanghai with clique consensus * Initial squashed commits for getting ``geth --dev`` test fixture working: - Quicker timeout for unmined wait-for-txn-receipt tests - Update default fees test for geth --dev mode - Get rid of all miner start() and stop() references - Run integration tests with --dev flag - Test refactoring for ``geth --dev`` test fixture setup - Remove PoW related endpoint tests; TODO: remove / deprecate endpoints - Support latest geth versions - Update geth version in circleCI config + peripherally related changes - Turn on PoS block identifier tests - get geth --dev test suite working * Updates towards ``geth --dev`` test fixture: - Flaky for replace transaction - Fix typing - Loosen assertions on gas - Nonce value fix - Loosen asserts for default maxFeePerGas and maxPriorityFeePerGas tests * ``geth --dev`` test fixture tweaks: - Add @flaky to tests that expect mining at certain times - This isn't ideal. Perhaps we can increase the ``dev.period`` (mining interval) to make these tests a bit more reliable and hopefully the other tests are unaffected. - Update benchmark to run with ``geth --dev`` setup - Put back old state of get_logs_without_logs for eth_tester * More work towards ``geth --dev`` test fixture: - Try with --dev.period=5 - Remove assert from test_eth_new_block_filter - Remove sleep from test_web3_client_version - Try without flaky - Fixes test_eth_send_transaction_with_nonce without the need for retries. - Retries were causing transactions to be sent with the same nonce, which in turn requires more gas to go through. Running the test once fixes this issue. - Obtain the transaction count providing the 'pending' argument. - Fix test_eth_send_transaction_no_max_fee * Additional cleanup for ``geth --dev`` test fixture * Sync with feedback in #3191 for ``geth --dev`` test fixture --------- Co-authored-by: fselmo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #3188
How was it fixed?
geth --devfor local chain that uses simulated PoS--devmode--devmodeTodo:
Cute Animal Picture