Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.7 to CI tests #968

Closed
dylanjw opened this issue Jul 24, 2018 · 8 comments · Fixed by #996
Closed

Add python 3.7 to CI tests #968

dylanjw opened this issue Jul 24, 2018 · 8 comments · Fixed by #996

Comments

@dylanjw
Copy link
Contributor

dylanjw commented Jul 24, 2018

What was wrong?

python 3.7 is out, and we should include it in our testing.

How can it be fixed?

add python 3.7 to our tox.ini & circleci config

@veox
Copy link
Contributor

veox commented Jul 25, 2018

For ref: ethereum/py-evm#970 - same-topic tracking issue in py-evm; with some initial findings - haven't revisited in 2 weeks.

@voith
Copy link
Contributor

voith commented Jul 25, 2018

python3.7 support in websockets was added in v6.0. So websocket version has to be bumped in web3 to 6.0.

@voith
Copy link
Contributor

voith commented Jul 29, 2018

In #973, someone has already tested HTTPProvider with python3.7 and it seems functional. websockets might be the only library that might need a version upgrade.

@voith
Copy link
Contributor

voith commented Jul 30, 2018

I tried testing python3.7 with my fork today, but the build is failing. https://circleci.com/gh/voith/web3.py/3206
Looks like we'll have to wait for py-evm to work with python3.7. Curently, plylevel gives the following error:

  plyvel/_plyvel.cpp:547:24: fatal error: leveldb/db.h: No such file or directory
   #include "leveldb/db.h"
                          ^
  compilation terminated.
  error: command 'gcc' failed with exit status 1

Looking at ethereum/py-evm#1109, it seems like it can fixed by bumping the plyvel version.

@veox
Copy link
Contributor

veox commented Aug 7, 2018

py-evm should now be good with Python 3.7.

@voith - seems you've already started working on this; could you craft a PR?..

@voith
Copy link
Contributor

voith commented Aug 7, 2018

@veox Thanks for informing. I was waiting for py-evm to be released, so that I can make the corresponding change in eth-tester and web3

@voith
Copy link
Contributor

voith commented Aug 7, 2018

waiting on ethereum/eth-tester#120

@voith
Copy link
Contributor

voith commented Aug 9, 2018

all blockers removed. #996 should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants