Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run blockchain tests as default on CI #374

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

holgerd77
Copy link
Member

With the latest test-related PR merge now using the sealEngine field from the tests - see #373 - blockchain tests are now fast enough to be run as default on every PR.

This PR:

  • Adds a default testBlockchain job to the CircleCI config
  • Removes the temporary helper CircleCI config for dedicated blockchain tests runs I once introduced, also removes the note on the documentation
  • Removes the randomly selected blockchain test runs (also once introduced by me)

Since there are still too many tests failing I will for now not yet activate this as mandatory. This should nevertheless help a lot improve PR quality (+ reduce failure introduction risk) and should also help us to easier fix the remaining failing blockchain tests, see #338.

@holgerd77
Copy link
Member Author

No production code touched, tests are still passing, will merge.

@holgerd77 holgerd77 merged commit 906eb6c into master Oct 30, 2018
@holgerd77 holgerd77 deleted the run-blockchain-tests-as-default branch October 30, 2018 20:55
This was referenced Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants