Skip to content
This repository has been archived by the owner on Jan 11, 2022. It is now read-only.

Rewrite in TypeScript #29

Closed
axic opened this issue Jul 28, 2018 · 5 comments
Closed

Rewrite in TypeScript #29

axic opened this issue Jul 28, 2018 · 5 comments

Comments

@axic
Copy link
Member

axic commented Jul 28, 2018

Part of ethereumjs/organization#28

@holgerd77
Copy link
Member

Don't know, how best to tackle this? Should this also break with taking different types as input for generic encode and decode functionality, like also mirrored in the TypeScript interface PR #25? Or do a breaking release with separate encodeString(),... methods? Just allow Buffer values?

Any other possible strategies?

@whymarrh
Copy link
Contributor

I think for starters (once #25 is merged) we can rewrite the project to produce that API. Once that's in place we can start updating the types. How do we feel about that?

@holgerd77
Copy link
Member

You don't have to wait for #25 to be merged, this is not very much code and @ukstv was not responsive on this lately (mostly due to our fault since this took ages to go forward this so I wouldn't blame if he lost patience). But in doubt get in short contact on this, I am no TypeScript expert, so I also have separately the question if these separate definition files are still necessary if one is rewriting the whole library?

I am otherwise ok with the procedure, to keep the API on first iteration - if this keeps things easier - and then change on that later on.

@holgerd77
Copy link
Member

@whymarrh Have sent you a message on Gitter, not sure, what is the best way to reach out to you? Anyhow, maybe respond there. 😄

@whymarrh
Copy link
Contributor

I think we can close this issue now that #37 has been merged 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants