From 28825463517f8821392464ec2283ee59c431d928 Mon Sep 17 00:00:00 2001 From: Richard Moore Date: Fri, 3 Apr 2020 21:32:44 -0400 Subject: [PATCH] Fail earlier when resolving an ENS name that is not a string. --- packages/providers/src.ts/base-provider.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/providers/src.ts/base-provider.ts b/packages/providers/src.ts/base-provider.ts index 63096013a4..4e0ef3b7ea 100644 --- a/packages/providers/src.ts/base-provider.ts +++ b/packages/providers/src.ts/base-provider.ts @@ -895,6 +895,10 @@ export class BaseProvider extends Provider { if (isHexString(name)) { throw error; } } + if (typeof(name) !== "string") { + logger.throwArgumentError("invalid ENS name", "name", name); + } + // Get the addr from the resovler const resolverAddress = await this._getResolver(name); if (!resolverAddress) { return null; }