Optimized strings prefix judge: use startsWith instead of substring #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
reviewed
Feb 18, 2023
| @@ -96,7 +96,7 @@ function getAccount(data: any, _key: string): KeystoreAccount { | |||
| const address = computeAddress(privateKey); | |||
| if (data.address) { | |||
| let check = data.address.toLowerCase(); | |||
| if (check.substring(0, 2) !== "0x") { check = "0x" + check; } | |||
| if (check.startsWith("0x")) { check = "0x" + check; } | |||
There was a problem hiding this comment.
This should be prefixed with !. But no worries, I caught it during merging. Just adding here for future observers. ;)
Thanks! :)
ricmoo
added a commit
that referenced
this pull request
Feb 19, 2023
|
Merged into v6.0.5. Thanks! :) |
ricmoo
added
fixed/complete
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startsWith() can show stronger semantics than substring, it tells that this method is to judge if a string starts with some substring.