Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error on Events triggering #3767 #3922

Closed
wants to merge 1 commit into from

Conversation

shirotech
Copy link

@ricmoo There might be a better way; not sure why the event is a JSON string in the first place. Perhaps it was JSON.stringify somewhere it shouldn't have?

@shirotech shirotech changed the title fix: fixes #3767 parse possible json string Fix: Error on Events triggering #3767 Mar 22, 2023
@ricmoo ricmoo added on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 labels Mar 27, 2023
@ricmoo
Copy link
Member

ricmoo commented Mar 28, 2023

A fix was included in v6.2.3.

Thanks! :)

@ricmoo ricmoo closed this Mar 28, 2023
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 28, 2023
@shirotech
Copy link
Author

Still trying to get contributor status lol

@ricmoo
Copy link
Member

ricmoo commented Mar 28, 2023

Oh yes. I need to port my contrib script from v5 to get the gitpoaps working again too. :)

Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants