Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing JsonRpcApiProviderOptions to BrowserProvider #4707

Closed

Conversation

corbanbrook
Copy link

Removed build artifacts from PR. replaces #4642

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. v6 Issues regarding v6 next-patch Issues scheduled for the next arch release. labels Apr 25, 2024
@pkieltyka
Copy link

hi @ricmoo any chance you'd be able to look at this simple PR for inclusion to a tiny release..?

@ricmoo
Copy link
Member

ricmoo commented May 15, 2024

It’s scheduled for the next minor release, which should be coming soon. I can prolly get it out this week.

I’ll get the changes merged today into the minor wip branch. :)

@pkieltyka
Copy link

amazing thank you

@pkieltyka
Copy link

hi @ricmoo sorry to be a bother, just wondering if you had a chance to look at this PR yet?

@ricmoo
Copy link
Member

ricmoo commented Jun 1, 2024

Sorry, got stuck on a Geth config update for geth-run-action.

I’ve fixed the start-up issue, but now I’m getting this error, “transaction indexing is in progress“ during eth_getTransactionReceipt calls.

If anyone can help out with this, that would be a huge help. Otherwise I’m hoping to resolve this tonight. :)

@ricmoo
Copy link
Member

ricmoo commented Jun 3, 2024

Quick question, if someone could get back to me ASAP; what parameter are you trying to override?

I'm thinking of restricting it to the subset of options that makes sense (i.e. remove all the batching properties), but want to make sure that doesn't break your intention.

Thanks! :)

ricmoo added a commit that referenced this pull request Jun 3, 2024
@corbanbrook
Copy link
Author

we need it to pass { cacheTimeout: -1 }

@ricmoo
Copy link
Member

ricmoo commented Jun 3, 2024

Perfect! Thanks. :)

@ricmoo
Copy link
Member

ricmoo commented Jun 4, 2024

This has been published in v6.13.0.

Try it out and let me know if there are any problems.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants