Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recognize ens domains #351

Merged
merged 5 commits into from
May 31, 2022
Merged

feat: recognize ens domains #351

merged 5 commits into from
May 31, 2022

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented Apr 25, 2022 •
edited
Loading

resolves #288

This is blocked by ENS request support on bee-js ethersphere/bee-js#647

todo:

  • do more thorough testing (actually test with ens resolver)
  • use this function on the input field

@bee-worker
Copy link
Collaborator

bee-worker commented Apr 25, 2022 •
edited
Loading

🐝 PR preview in Swarm

Preview URL: https://bah5acgzadmcfv56sl4ouvkmkfiidml6dkwstd54cbyyqsifbzz5xomebmrda.bzz.link
Swarm Hash: 1b045af7d25f1d4aa98a2a10362fc355a531f7820e310920a1ce7b7730816446
Commit Hash: cd34b1c
Commit Message: fix: asset summary component to support ENS issue

@vojtechsimetka vojtechsimetka mentioned this pull request Apr 27, 2022
Closed
@vojtechsimetka vojtechsimetka added the status:blocked Unable to be worked further until needs are met (see 'need:*' category) label Apr 27, 2022
@vojtechsimetka vojtechsimetka marked this pull request as ready for review May 30, 2022 16:00
@vojtechsimetka vojtechsimetka merged commit 5917a13 into master May 31, 2022
@vojtechsimetka vojtechsimetka deleted the feat/recognize-ens-domains branch May 31, 2022 11:37
@bee-worker bee-worker mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cafe137 Cafe137 Cafe137 approved these changes

Assignees
No one assigned
Labels
status:blocked Unable to be worked further until needs are met (see 'need:*' category) type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ENS name support for downloading
3 participants
@vojtechsimetka @bee-worker @Cafe137