Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ci pipeline for postage smart contract #902

Closed
Eknir opened this issue Nov 3, 2020 · 4 comments
Closed

Setup ci pipeline for postage smart contract #902

Eknir opened this issue Nov 3, 2020 · 4 comments
Assignees
Labels

Comments

@Eknir
Copy link
Contributor

Eknir commented Nov 3, 2020

Task

  • Setup ci pipeline for postage smart contract

Acceptance criterea

  • CI pipeline set-up
    • unit tests run on every pr and merge on master
    • coverage run on every pr and merge on master
    • linting run on every pr and merge on master
    • go bindings are generated and pushed on release tags
@bee-runner bee-runner bot added the issue label Nov 3, 2020
@Eknir
Copy link
Contributor Author

Eknir commented Nov 3, 2020

@ralph-pichler , could you please formulate better acceptance criteria here?

@ralph-pichler
Copy link
Member

@Eknir done, but this should probably be multiple issues

@Eknir Eknir added this to the Sprint 3.2 milestone Nov 4, 2020
@Eknir
Copy link
Contributor Author

Eknir commented Nov 30, 2020

@paxthemax , I think we concluded together to temporarily de-prioritize this one, right? At least until the whole storage incentive is more stabilized and mature.

If that is the case, could you please be so kind to move this issue to the Icebox?

@ralph-pichler
Copy link
Member

At the very least the scripts to generate the bindings should be in the repo before this is ever used on the go side. Ideally though we also generate those already automatically as manually calling them can lead to human error (e.g. running it on wrong branch or with pending changes, this actually happened when we implemented swap and caused quite a few hours of headache).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants