Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap endpoint does not work with generated password #258

Closed
agazso opened this issue Sep 7, 2022 · 0 comments · Fixed by #261
Closed

Swap endpoint does not work with generated password #258

agazso opened this issue Sep 7, 2022 · 0 comments · Fixed by #261
Assignees
@Cafe137
Labels
bug Something isn't working issue

Comments

@agazso
Copy link
Member

agazso commented Sep 7, 2022

Because the functionality still uses the hardcoded Test password:

swarm-desktop/src/server.ts

Line 200 in 903cfa1

const wallet = await Wallet.fromV3(v3, 'Test')

Related PR: #239
@bee-runner bee-runner bot added the issue label Sep 7, 2022
@agazso agazso added the bug Something isn't working label Sep 7, 2022
@Cafe137 Cafe137 self-assigned this Sep 7, 2022
@Cafe137 Cafe137 linked a pull request Sep 9, 2022 that will close this issue
fix: read current password when constructing v3 wallet #261
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cafe137 Cafe137

Labels
bug Something isn't working issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: read current password when constructing v3 wallet ethersphere/swarm-desktop
2 participants
@agazso @Cafe137