feat: add os agnostic build system #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I test this without having windows somehow? Any idea? :) |
Gave up on it, I built a Windows PC 😄 |
You may want to try Windows in a VirtualBox, that's what I do. |
Comment on lines
+1
to
+42
| const { existsSync, writeFileSync } = require('fs') | ||
| const { copySync } = require('fs-extra') | ||
| const { join } = require('path') | ||
| const { platform } = require('os') | ||
| const { default: fetch } = require('node-fetch') | ||
| const { execSync } = require('child_process') | ||
|
|
||
| const binaries = { | ||
| darwin: ['https://github.com/ethersphere/bee/releases/download/v1.5.1/bee-darwin-amd64', 'bee'], | ||
| linux: ['https://github.com/ethersphere/bee/releases/download/v1.5.1/bee-linux-amd64', 'bee'], | ||
| win32: ['https://github.com/ethersphere/bee/releases/download/v1.5.1/bee-windows-amd64.exe', 'bee.exe'], | ||
| } | ||
|
|
||
| module.exports = { | ||
| generateAssets: async () => { | ||
| const target = binaries[platform()] | ||
| if (!existsSync(target[1])) { | ||
| await downloadFile(target[0], target[1]) | ||
| try { | ||
| execSync(`chmod +x ${target[1]}`) | ||
| } catch {} | ||
| } | ||
| }, | ||
| postPackage: (_, options) => { | ||
| if (existsSync('bee')) { | ||
| copySync('bee', join(options.outputPaths[0], 'bee')) | ||
| } | ||
| if (existsSync('bee.exe')) { | ||
| copySync('bee.exe', join(options.outputPaths[0], 'bee.exe')) | ||
| } | ||
| copySync('tray.png', join(options.outputPaths[0], 'tray.png')) | ||
| copySync('[email protected]', join(options.outputPaths[0], '[email protected]')) | ||
| copySync('icon.png', join(options.outputPaths[0], 'icon.png')) | ||
| copySync('static', join(options.outputPaths[0], 'static')) | ||
| }, | ||
| } | ||
|
|
||
| function downloadFile(url, target) { | ||
| return fetch(url) | ||
| .then(x => x.arrayBuffer()) | ||
| .then(x => writeFileSync(target, Buffer.from(x))) | ||
| } |
There was a problem hiding this comment.
I know this is POC but can these be in typescript? Happy to help.
There was a problem hiding this comment.
Should be fine, it is not very obvious since this script is specified in package.json as a property of forge but I'll check 🙂
vojtechsimetka
approved these changes
Apr 12, 2022
Comment on lines
+1
to
+42
| const { existsSync, writeFileSync } = require('fs') | ||
| const { copySync } = require('fs-extra') | ||
| const { join } = require('path') | ||
| const { platform } = require('os') | ||
| const { default: fetch } = require('node-fetch') | ||
| const { execSync } = require('child_process') | ||
|
|
||
| const binaries = { | ||
| darwin: ['https://github.com/ethersphere/bee/releases/download/v1.5.1/bee-darwin-amd64', 'bee'], | ||
| linux: ['https://github.com/ethersphere/bee/releases/download/v1.5.1/bee-linux-amd64', 'bee'], | ||
| win32: ['https://github.com/ethersphere/bee/releases/download/v1.5.1/bee-windows-amd64.exe', 'bee.exe'], | ||
| } | ||
|
|
||
| module.exports = { | ||
| generateAssets: async () => { | ||
| const target = binaries[platform()] | ||
| if (!existsSync(target[1])) { | ||
| await downloadFile(target[0], target[1]) | ||
| try { | ||
| execSync(`chmod +x ${target[1]}`) | ||
| } catch {} | ||
| } | ||
| }, | ||
| postPackage: (_, options) => { | ||
| if (existsSync('bee')) { | ||
| copySync('bee', join(options.outputPaths[0], 'bee')) | ||
| } | ||
| if (existsSync('bee.exe')) { | ||
| copySync('bee.exe', join(options.outputPaths[0], 'bee.exe')) | ||
| } | ||
| copySync('tray.png', join(options.outputPaths[0], 'tray.png')) | ||
| copySync('[email protected]', join(options.outputPaths[0], '[email protected]')) | ||
| copySync('icon.png', join(options.outputPaths[0], 'icon.png')) | ||
| copySync('static', join(options.outputPaths[0], 'static')) | ||
| }, | ||
| } | ||
|
|
||
| function downloadFile(url, target) { | ||
| return fetch(url) | ||
| .then(x => x.arrayBuffer()) | ||
| .then(x => writeFileSync(target, Buffer.from(x))) | ||
| } |
This was referenced Feb 23, 2023
This was referenced Mar 28, 2023
This was referenced Apr 27, 2023
This was referenced Aug 11, 2023
This was referenced Dec 6, 2023
This was referenced Jun 3, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.