Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

fix inconsistencies in POT iterators #1053

Closed
zelig opened this issue Dec 13, 2018 · 0 comments
Closed

fix inconsistencies in POT iterators #1053

zelig opened this issue Dec 13, 2018 · 0 comments

Comments

@zelig
Copy link
Member

zelig commented Dec 13, 2018

FYI there seems to be bugs in the pot iterators. Fortunately, the buggy parts don't seem to be used by anything outside the package

  • Each and EachFrom return the "pinned" Val even though comment says they doen't
  • Each and EachFrom report the "pinned" Val as po = 0 instead of the correct po = 256
  • EachBin passes a po value to both its outer and inner iterator. The inner one seems to be unreliable.

All these POs are not well defined, i recommend we eliminate this argument from the iterator function

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants