Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Refactor kademlia.EachBin #1071

Closed
holisticode opened this issue Dec 19, 2018 · 2 comments
Closed

Refactor kademlia.EachBin #1071

holisticode opened this issue Dec 19, 2018 · 2 comments
Labels
kademlia

Comments

@holisticode
Copy link
Contributor

The kademlia.EachBin function is utterly complex and very difficult to reason about, and lacking documentation to understand it.

It is currently exclusively used to evaluate which bins the streamer syncing protocol needs to subscribe to for pull syncing.

It should be refactored and documented
@holisticode holisticode mentioned this issue Dec 19, 2018
Closed
@zelig zelig mentioned this issue Dec 19, 2018
Closed
53 tasks
@holisticode
Copy link
Contributor Author

The PR addressing this is ethereum/go-ethereum#18355

@frncmx frncmx mentioned this issue Jan 7, 2019
Closed
@zelig
Copy link
Member

zelig commented Jan 11, 2019

merged as ethereum/go-ethereum#18355

@zelig zelig closed this as completed Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kademlia
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holisticode @zelig