Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault Proof support for hybrid DA #55

Open
2 of 3 tasks
qizhou opened this issue Sep 9, 2024 · 4 comments
Open
2 of 3 tasks

Fault Proof support for hybrid DA #55

qizhou opened this issue Sep 9, 2024 · 4 comments
Assignees

Comments

@qizhou
Copy link

qizhou commented Sep 9, 2024

Currently, we do not support fault-proof

  • some parameters (e.g., enablel2blob) are passed via CLI, which should be in the rollup config
  • some parameters should be moved out of rollup config (e.g., DAC lists)

sub issues:

@qizhou qizhou changed the title Fault Proof support Fault Proof support for hybrid DA Sep 10, 2024
@blockchaindevsh
Copy link

blockchaindevsh commented Sep 13, 2024

I think to enable BLOB challenge, we need to insert a BLOB challenge module into the pipeline, similar to how AltDA works now:

  1. This module M should be inserted after BatchQueue module.
  2. M needs to parse the Batch and record all BLOBs and corresponding L1 Origin block.
  3. M needs to record all BLOB challenges within BLOB challenge window.
  4. If M detects expired challenge for some BLOBs, it should record it and then trigger a reorg, and finally when deriving the batch a second time, it should exclude those BLOB txs from the batch.
    1. M needs to fix up parent hash of subsequent batches.(can reference how steady batch derivation works)

Question:
If both AltDA challenge and BLOB challenge are enabled, what's the expected relationship between AltDA window and BLOB window? My intuition is the effective window should be max(AltDA window, BLOB window).

@qizhou
Copy link
Author

qizhou commented Sep 13, 2024

Question: If both AltDA challenge and BLOB challenge are enabled, what's the expected relationship between AltDA window and BLOB window? My intuition is the effective window should be max(AltDA window, BLOB window).

I think we can just reuse the same parameters (challengeWindow, resolveWindow) for both of them.

@qizhou
Copy link
Author

qizhou commented Sep 14, 2024

We need specific sub-issues and assignees for the subtask.

@blockchaindevsh
Copy link

We need specific sub-issues and assignees for the subtask.

Updated .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants