-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified Fides] Populate Application DB instead of Test DB #1175
Comments
See #1162 for more discussion |
I think an acceptable solution for this in the near-term could also be to rename the usages of Fidesops' definition of |
Looking into how to change the DB connection URL based on a config var in ctl code, we should already be able to change ops code to do this since this was fidesops worked initially. |
@pattisdr has suggested we hold off on merging this until after the Fidesplus 2.0 launch, great idea thanks! |
Temporarily moving to blocked until unified fides work is done. I have one failing end-to-end test on Fides Connectors after getting this up-to-date with main. It's a tricky one to debug. |
Is your feature request related to a specific problem?
Currently, Fides has a "Test mode" setting which populates the test db when True, and the application db when False. Test mode seems to be True by default. So when running the application locally, it is the test db that is getting populated.
Fidesops had "test mode" as False by default. It was not meant to be set as True by anyone, it was just a variable that Pytest set to True to have the Test DB be used.
For the Fidesops side of things, it is useful to have a separate database from the test database when you're testing privacy requests locally, and depending on some resources to persist there without being created and torn down by the testing harness.
Describe the solution you'd like
EDIT ON October 20, 2022 by @ThomasLaPiana:
After more discussion in the initial PR that is now closed, it was determined that the right way to go forward is the following:
The text was updated successfully, but these errors were encountered: