Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fideslib into unified-fides #1572

Closed
ThomasLaPiana opened this issue Oct 26, 2022 · 2 comments · Fixed by #1859
Closed

Merge fideslib into unified-fides #1572

ThomasLaPiana opened this issue Oct 26, 2022 · 2 comments · Fixed by #1859
Assignees

Comments

@ThomasLaPiana
Copy link
Contributor

ThomasLaPiana commented Oct 26, 2022

Is your feature request related to a specific problem?

Now that everything is merged into a single project, the additional friction of updating fideslib is no longer worth it since it is no longer enabling code-sharing. Case in point, PRs like this become more complicated as we end up circumventing fideslib altogether instead of trying to fix it properly and cut another release.

Describe the solution you'd like

Copy/pasta, keeping the git history doesn't seem particularly important here given the additional complexity

@ThomasLaPiana
Copy link
Contributor Author

@NevilleS @seanpreston FYI this is on my mind. That repo is now devoid of its original purpose and should be folded back in (the arms of unified-fides are ever-open to embrace more code)

@sanders41
Copy link
Contributor

@ThomasLaPiana I agree, now that fidesctl and fidesops are merged we could move faster by also merging fideslib in. It should be relatively painless to merge in (famous last words right?).

I also agree that keeping the git history would be more trouble than it is worth here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants