Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the connector configuration dataset YAML upload form #2114

Closed
allisonking opened this issue Dec 23, 2022 · 6 comments · Fixed by #2162
Closed

Remove the connector configuration dataset YAML upload form #2114

allisonking opened this issue Dec 23, 2022 · 6 comments · Fixed by #2162

Comments

@allisonking
Copy link
Contributor

Is your feature request related to a specific problem?

There are two YAML forms that can be used to create datasets right now, one from the dataset management UI, and one from the connector configuration management UI. We should only have one now that we are unifying the ops and ctl datasets

Describe the solution you'd like

IMO it would make sense to remove the connector configuration YAML form:

Screen Shot 2022-11-14 at 10 08 02

And replace it with a multiselect that allows you to connect existing datasets to this connector. If they need to create a new one, then we should redirect them to the dataset management UI to create a dataset.

Describe alternatives you've considered, if any

Leave as-is, but there are some caveats described in #2113 which make this UX a bit strange if we leave it.

Additional context

Follow up to #1766

I'd like to get @rsilvery 's thoughts on how/if we should go about this. If we do, we may also need designs.

@rsilvery
Copy link
Contributor

rsilvery commented Jan 4, 2023

I know we'd like to keep the more featured one. Working with @mfbrown to figure out how to sunset one of them.

@rsilvery
Copy link
Contributor

rsilvery commented Jan 5, 2023

Most of this is being handled in #1531. We need to make sure that there's some protection to prevent overwriting datasets.

@rsilvery
Copy link
Contributor

rsilvery commented Jan 5, 2023

Suggestion from @mfbrown : check for the existence of the fides key for the dataset and, if found, confirm user wants to overwrite.

@allisonking
Copy link
Contributor Author

#1531 will handle upgrading the dataset YAML form to use the same YAML editor as the connector one.

This ticket should focus on replacing the existing YAML form with a select dropdown of existing ctl datasets. If the dataset the user wants to link does not exist yet, we should redirect them to the adding a dataset flow.

@allisonking
Copy link
Contributor Author

Decision:

  • Add a drop down to the Connectors dataset UI to select an existing dataset.
  • If a dataset is selected in this menu, the editor is disabled. If it's unselected, the editor returns
  • Once we've implemented this and can show it to design, get feedback and adapt as needed.

@pattisdr
Copy link
Contributor

pattisdr commented Jan 8, 2023

Nice path forward here! ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants