Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After saving edits to a system in the "View systems" page, warning modal about unsaved changes still appears #2788

Closed
NevilleS opened this issue Mar 10, 2023 · 2 comments · Fixed by #2826
Assignees
Labels
bug Something isn't working

Comments

@NevilleS
Copy link
Contributor

Bug Description

When editing a system via the UI, the "Unsaved changes" modal will popup even after saving, which is unexpected. However, when you reload / refresh, the changes are definitely saved, so this modal is just triggering incorrectly.

Steps to Reproduce

  1. Run `nox -s "fides_env(test)"
  2. Navigate to "Data map" > "View systems", loads the default "System information" tab
  3. Edit any system
  4. Make a change to the system, hit "Save"
  5. Navigate to the "Data use" tab
  6. See an unexpected popup warning:
    image

Expected behavior

Since I've already saved my changes, the form shouldn't be considered "dirty" and the warning isn't needed.

Environment

  • Version: 2.8.1
  • OS: Mac OSX
  • Python Version: 3.9.6
  • Docker Version: Docker version 20.10.22, build 3a2c30b

Additional Context

Please update the systems.cy.ts Cypress tests to remove the unnecessary cy.getByTestId("continue-btn").click() call to dismiss this popup once it's fixed 👍

@rsilvery
Copy link
Contributor

rsilvery commented Mar 13, 2023

Further testing shows it's not related to whether any updates are made. Any time you click on the data use tab this pop-up appears: https://www.loom.com/share/5ecaf5ee58114e0abf74eb7570f0064e

@Kelsey-Ethyca
Copy link
Contributor

QA'd and moving to done 🌵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants