Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete buttons should trigger a confirmation modal #773

Closed
allisonking opened this issue Jun 16, 2022 · 1 comment
Closed

Delete buttons should trigger a confirmation modal #773

allisonking opened this issue Jun 16, 2022 · 1 comment
Assignees
Labels
UI Work related to UI

Comments

@allisonking
Copy link
Contributor

Is your feature request related to a specific problem?

The delete buttons will very quickly just delete a thing right now. We should have a confirmation step, as this action is not easily reversible.

Describe the solution you'd like

Per the designs, and in line with the user management flow, we should have a delete modal which requires the user to retype the name of the field they are deleting, then allow actually deleting.

Describe alternatives you've considered, if any

No deleting confirmation, or perhaps a deleting confirmation that does not require retyping the name, just a second button?

Additional context

Would build off of the work done in #762

@allisonking allisonking added enhancement UI Work related to UI labels Jun 16, 2022
@allisonking allisonking added this to the 1.7.0 milestone Jun 16, 2022
@allisonking allisonking self-assigned this Jun 16, 2022
@mfbrown mfbrown modified the milestones: 1.7.0, 1.7.1 Jun 21, 2022
@allisonking
Copy link
Contributor Author

Closing as duplicate of #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Work related to UI
Projects
None yet
Development

No branches or pull requests

2 participants