Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 0.0.0.0 host in endpoint property #67

Closed
eastandwestwind opened this issue Jun 17, 2022 · 0 comments · Fixed by #68
Closed

Allow 0.0.0.0 host in endpoint property #67

eastandwestwind opened this issue Jun 17, 2022 · 0 comments · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@eastandwestwind
Copy link
Contributor

Our validator lib does not allow 0.0.0.0 in a url:

>>> from validators import url as is_valid_url
>>> is_valid_url("http://0.0.0.0/health")
ValidationFailure(func=url, args={'value': 'http://0.0.0.0/health', 'public': False})

But it will allow localhost and other local addresses

>>> is_valid_url("http://localhost:8080/health")
True
>>> is_valid_url("http://127.0.0.1/health")
True
>>> is_valid_url("http://127.0.0.0/health")
True

We will be sending 0.0.0.0 from fidesops, so let's specifically allow for this in fideslog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants