Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to suppress debug output #36

Closed
astumpf opened this issue Sep 26, 2023 · 4 comments · Fixed by #37
Closed

Config option to suppress debug output #36

astumpf opened this issue Sep 26, 2023 · 4 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request

Comments

@astumpf
Copy link

astumpf commented Sep 26, 2023

Context
When running Wavemap we are seeing a lot of output spam

INFO|1695678518.782757590|/wavemap|ros.wavemap_ros: Integrated new pointcloud in 0.00649134s. Total integration time: 12.584s.
INFO|1695678518.826786662|/wavemap|ros.wavemap_ros: Inserting pointcloud with 28800 points. Remaining pointclouds in queue: 0.
INFO|1695678518.833032240|/wavemap|ros.wavemap_ros: Integrated new pointcloud in 0.00619076s. Total integration time: 12.5902s.
INFO|1695678518.976278673|/wavemap|ros.wavemap_ros: Inserting pointcloud with 28800 points. Remaining pointclouds in queue: 0.

Requested feature

Add an option to suppress any debug messages such as those:

ROS_INFO_STREAM("Inserting pointcloud with "

ROS_INFO_STREAM("Integrated new pointcloud in "

(Optional) Suggest a solution
Extend the config field by a new bool to enable debug output.

DECLARE_CONFIG_MEMBERS(PointcloudInputHandlerConfig,

@astumpf astumpf added the enhancement New feature or request label Sep 26, 2023
@victorreijgwart
Copy link
Member

victorreijgwart commented Sep 27, 2023

Hi Alexander, thanks for filing this feature request. I'll go through wavemap's logging messages and add more verbosity controls later this week.

For a temporary fix, it should be possible to reduce spam by setting the logger levels to only emit warnings and higher. Note that wavemap's ROS wrapper uses ROS's native logging but the libraries use GLOG (since they're ROS agnostic), so it's necessary to set both. To configure

  • GLOG, add args="--minloglevel=1" to the params used to launch the wavemap node (GLOG documentation)
  • ROS's native logging, you can use this service call
<node name="set_wavemap_log_level" pkg="rosservice" type="rosservice" args="call --wait /wavemap/set_logger_level 'ros.wavemap_ros' 'warn'" />

@victorreijgwart victorreijgwart linked a pull request Sep 29, 2023 that will close this issue
6 tasks
@victorreijgwart
Copy link
Member

victorreijgwart commented Sep 29, 2023

PR #37 adds an option to set the logging level under:

map:
  general: 
    logging_level: info

The options are debug, info, warning, error, and fatal. I lowered the severity for the timing-related messages such that they only show up when the level is set to debug. This way wavemap is already relatively quiet when running at the default info level. Let me know if this solves your issue.

@astumpf
Copy link
Author

astumpf commented Oct 13, 2023

So logging_level: info is already default? I've tested that version and even without any changes on my config I didn't get any "spam" prints anymore.

@victorreijgwart
Copy link
Member

victorreijgwart commented Oct 16, 2023

Yes, info is the default level.
Great. Then I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants