Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules/50-udev-default.rules: add PTP entry for Hyper-V/Azure #218

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

dermotbradley
Copy link
Contributor

udev rules: add rule to create /dev/ptp_hyperv

As for the KVM case, necessary for network cards with
PTP devices when running a guest on HyperV

systemd-commit: 32e868f058da8b90add00b2958c516241c532b70
Author: Luca Boccassi [email protected]
Date: Fri Feb 26 10:25:31 2021 +0000

udev rules: add rule to create /dev/ptp_hyperv

As for the KVM case, necessary for network cards with
PTP devices when running a guest on HyperV

systemd-commit: 32e868f058da8b90add00b2958c516241c532b70
Author: Luca Boccassi <[email protected]>
Date:   Fri Feb 26 10:25:31 2021 +0000
@ArsenArsen
Copy link
Member

Does this work? I don't have a hyperv system to test on currently

@dermotbradley
Copy link
Contributor Author

Does this work? I don't have a hyperv system to test on currently

I don't see why it would not work - it has been present in Systemd's udev rules for almost 1 year.

I also do not have a Hyper-V system to test on but need this change as I will shortly be testing Chrony using PTP on Azure (which uses the same kernel module) - this PR is part of my preparations for doing that.

In order to test this you need to have the hv_utils kernel module loaded.

@ArsenArsen
Copy link
Member

I don't see why it would not work - it has been present in Systemd's udev rules for almost 1 year.

In case some supporting code for this is missing, it could become a no-op.

If you remember, please do tell us how testing on Azure goes, if you're unable to, I can probably get Hyper-V somewhere later this week or maybe next week.

Thanks!

@kaniini
Copy link
Member

kaniini commented Mar 15, 2022

In this case, it is fine to merge without testing, as it is just adding another PTP subsystem entry. All the support code is there, already.

@kaniini kaniini merged commit 931c8e9 into eudev-project:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants