Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Vietnam #66

Closed
c933103 opened this issue Mar 11, 2019 · 1 comment
Closed

Split Vietnam #66

c933103 opened this issue Mar 11, 2019 · 1 comment
Milestone

Comments

@c933103
Copy link

c933103 commented Mar 11, 2019

I have thought a bit more about it. Regardless of whether the project use backzone or not, Northern Vietnam will still be in a different timezone than Southern Vietnam in timezone database. (Southern Vietnam is always Asia/Ho_Chi_Minh, while Northern Vietnam is either Asia/Hanoi in backzone or Asia/Bangkok in the standard dataset.)

Thus, as the timezone-bondary-buioder's objective is to create a geographical correspondence for the tz database, it seems appropriate to split Vietnam to reflect this difference in tz database.

As for exactly how to split it into different zone, I guess https://en.wikipedia.org/wiki/Vietnamese_Demilitarized_Zone would be a reasonable starting point.

@evansiroky
Copy link
Owner

Your comment in #65 is quite relevant:

The tricky thing here is Asia/Hanoi which have more data in the backzone tab and not just simply a link

I'm actually leaning towards using Asia/Bangkok to keep this library compatible with the current tz database. This would be the first area where a timezone identifier from another country will be used, but as you mention, it's probably the right thing to do.

As for geographic boundaries, it looks like the Quang Tri Province was the northernmost province of South Vietnam, so that could be the boundary.

South Vietnam Map

Here's a link to the relation in OSM.

@evansiroky evansiroky added this to the Next Release milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants