From 12178e3b46cfb4ef9083f2a2007d05f9ae42422c Mon Sep 17 00:00:00 2001
From: Evan Wallace <evan.exe@gmail.com>
Date: Mon, 8 Mar 2021 20:28:17 -0800
Subject: [PATCH] fix js target affecting css

---
 internal/compat/css_table.go |  4 ++++
 scripts/js-api-tests.js      | 23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/internal/compat/css_table.go b/internal/compat/css_table.go
index e1350f16926..493e5e98ddb 100644
--- a/internal/compat/css_table.go
+++ b/internal/compat/css_table.go
@@ -48,6 +48,10 @@ var cssTable = map[CSSFeature]map[Engine][]int{
 func UnsupportedCSSFeatures(constraints map[Engine][]int) (unsupported CSSFeature) {
 	for feature, engines := range cssTable {
 		for engine, version := range constraints {
+			if engine == ES {
+				// Specifying "--target=es2020" shouldn't affect CSS
+				continue
+			}
 			if minVersion, ok := engines[engine]; !ok || isVersionLessThan(version, minVersion) {
 				unsupported |= feature
 			}
diff --git a/scripts/js-api-tests.js b/scripts/js-api-tests.js
index fdcd45a88b9..797d0677fe3 100644
--- a/scripts/js-api-tests.js
+++ b/scripts/js-api-tests.js
@@ -2741,6 +2741,29 @@ let transformTests = {
     assert.strictEqual(code, `.π:after {\n  content: "π";\n}\n`)
   },
 
+  async cssMinify({ esbuild }) {
+    const { code } = await esbuild.transform(`div { color: #abcd }`, { loader: 'css', minify: true })
+    assert.strictEqual(code, `div{color:#abcd}\n`)
+  },
+
+  // Using an "esN" target shouldn't affect CSS
+  async cssMinifyTargetES6({ esbuild }) {
+    const { code } = await esbuild.transform(`div { color: #abcd }`, { loader: 'css', minify: true, target: 'es6' })
+    assert.strictEqual(code, `div{color:#abcd}\n`)
+  },
+
+  // Using an older browser target should affect CSS
+  async cssMinifyTargetChrome8({ esbuild }) {
+    const { code } = await esbuild.transform(`div { color: #abcd }`, { loader: 'css', minify: true, target: 'chrome8' })
+    assert.strictEqual(code, `div{color:rgba(170,187,204,.867)}\n`)
+  },
+
+  // Using a newer browser target shouldn't affect CSS
+  async cssMinifyTargetChrome80({ esbuild }) {
+    const { code } = await esbuild.transform(`div { color: #abcd }`, { loader: 'css', minify: true, target: 'chrome80' })
+    assert.strictEqual(code, `div{color:#abcd}\n`)
+  },
+
   async cjs_require({ esbuild }) {
     const { code } = await esbuild.transform(`const {foo} = require('path')`, {})
     assert.strictEqual(code, `const {foo} = require("path");\n`)