From 6f40235afb5e5ccd62b71bafd144b9a34374d6cb Mon Sep 17 00:00:00 2001
From: Evan Wallace <evan.exe@gmail.com>
Date: Sat, 23 Oct 2021 12:03:15 -0400
Subject: [PATCH] fix #1703: handle silent "rename" syscall failure

---
 CHANGELOG.md            | 6 ++++++
 lib/npm/node-install.ts | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ae4ba6f0d8c..713512b7565 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+* Fix using `npm rebuild` with the `esbuild` package ([#1703](https://github.com/evanw/esbuild/issues/1703))
+
+    Version 0.13.4 accidentally introduced a regression in the install script where running `npm rebuild` multiple times could fail after the second time. The install script creates a copy of the binary executable using [`link`](https://man7.org/linux/man-pages/man2/link.2.html) followed by [`rename`](https://www.man7.org/linux/man-pages/man2/rename.2.html). Using `link` creates a hard link which saves space on the file system, and `rename` is used for safety since it atomically replaces the destination.
+
+    However, the `rename` syscall has an edge case where it silently fails if the source and destination are both the same link. This meant that the install script would fail after being run twice in a row. With this release, the install script now deletes the source after calling `rename` in case it has silently failed, so this issue should now be fixed. It should now be safe to use `npm rebuild` with the `esbuild` package.
+
 * Fix invalid CSS minification of `border-radius` ([#1702](https://github.com/evanw/esbuild/issues/1702))
 
     CSS minification does collapsing of `border-radius` related properties. For example:
diff --git a/lib/npm/node-install.ts b/lib/npm/node-install.ts
index 3a9a296cf75..1814f1f9f67 100644
--- a/lib/npm/node-install.ts
+++ b/lib/npm/node-install.ts
@@ -169,6 +169,12 @@ function maybeOptimizePackage(binPath: string): void {
       // If we get here, then we know that the target location is now a binary
       // executable instead of a JavaScript file.
       isToPathJS = false;
+
+      // If this install script is being re-run, then "renameSync" will fail
+      // since the underlying inode is the same (it just returns without doing
+      // anything, and without throwing an error). In that case we should remove
+      // the file manually.
+      fs.unlinkSync(tempPath);
     } catch {
       // Ignore errors here since this optimization is optional
     }