Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform option to transform js api #2362

Closed
remorses opened this issue Jun 30, 2022 · 1 comment
Closed

Add platform option to transform js api #2362

remorses opened this issue Jun 30, 2022 · 1 comment

Comments

@remorses
Copy link
Contributor

remorses commented Jun 30, 2022 •
edited
Loading

Currently transform is missing the platform option

This option is useful to annotate commonjs named exports so that node can statically analyze them and let you use named imports on commonjs files
@remorses remorses mentioned this issue Jun 30, 2022
Closed
@privatenumber
Copy link
Contributor

Duplicate of #2248, which was closed because Node.js actually directly reads the file from disk (bypassing any transformers like esbuild) to statically analyze the exports.

@evanw evanw closed this as completed in 8759590 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@privatenumber @remorses