Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simply changing the publicUrl results in the same [hash] #2403

Closed
ZipBrandon opened this issue Jul 20, 2022 · 1 comment
Closed

Simply changing the publicUrl results in the same [hash] #2403

ZipBrandon opened this issue Jul 20, 2022 · 1 comment

Comments

@ZipBrandon
Copy link

I ran into this as I was switching S3 buckets on my testing environment and accidentally uploaded my assets to my production S3 bucket. I would have expected the unique content to have created new hash and have created no issues for this erroneous upload. Unfortunately, the hashing collisions overwrote the production assets.

Is this intended to exclude publicUrl from the [hash] calculation?
@evanw
Copy link
Owner

evanw commented Jul 23, 2022

No, this was an oversight. Thanks for the bug report. I'll fix this.

@evanw evanw closed this as completed in f41b38d Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanw @ZipBrandon