Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion to pin pr with 0.9.0 wip and also link it in docs #939

Closed
vladmandic opened this issue Mar 10, 2021 · 6 comments
Closed

suggestion to pin pr with 0.9.0 wip and also link it in docs #939

vladmandic opened this issue Mar 10, 2021 · 6 comments

Comments

@vladmandic
Copy link

i've just updated to 0.9.0 and got hit with no less than 5 breaking changes (metafile and banner changes, removal of service, etc.)
none bad and all are desirable, but took some searching to fix them

suggestion to pin your pr #924 with 0.9.0 wip notes as top-level issue and also link it in docs

@nettybun
Copy link

It's semver versioning. The 0 means that minor version changes are breaking changes. Evan said that as the first line in the changelog too.

@vladmandic
Copy link
Author

vladmandic commented Mar 10, 2021

i understand that and i forced major version update myself (eyes wide open).
but documentation of changes is not easy to find as the notes in the PR that is most helpful is closed as merged.

and changelog does contain same info, but it's also not linked anywhere nor does search on github show results from it prominently.

@vladmandic vladmandic changed the title suggestion to pin pr with 0.90 wip and also link it in docs suggestion to pin pr with 0.9.0 wip and also link it in docs Mar 10, 2021
@nettybun
Copy link

It's on the front page of https://github.com/evanw/esbuild in all caps as CHANGELOG.md which is a common community practice... I don't mean to argue about it but I think the rollout was done well

@vladmandic
Copy link
Author

It's a suggestion as changelog is not linked in readme at all, you have to view list of files.

And like i said, i love esbuild and have no issues how rollout was done otherwise.

@avindra
Copy link

avindra commented Mar 10, 2021

Been packaging esbuild since January and here is what I've observed:

All change notes can be found on the release tag on GitHub. E.g., for 0.9.0:

https://github.com/evanw/esbuild/releases/tag/v0.9.0

Similarly it's reflected in CHANGELOG.md:

https://github.com/evanw/esbuild/blob/master/CHANGELOG.md#090

Between these, I can always find what I need.

@vladmandic
Copy link
Author

ok, i guess i'll close this suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants