fix: remove duplicate fragments (fix #90) #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
commented
May 17, 2019
| @@ -1,6 +1,15 @@ | |||
| // @flow | |||
| import gqlTag from 'graphql-tag'; | |||
| import serialize from 'babel-literal-to-ast'; | |||
| import template from '@babel/template'; | |||
|
|
|||
| const uniqueFn = template.ast(` | |||
There was a problem hiding this comment.
Basically we append this function inside a .reduce call after the .concat we use to append the fragments.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 95.83% 95.91% +0.08%
==========================================
Files 5 5
Lines 48 49 +1
Branches 8 8
==========================================
+ Hits 46 47 +1
Misses 2 2
Continue to review full report at Codecov.
|
|
Accept the PR for now. I have not come up with a better solution to reduce runtime, either. |
evenchange4
changed the title
FezVrasta
changed the title
evenchange4
added a commit
that referenced
this pull request
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we deduplicate fragments at runtime.
I wanted to do this at build time inside Babel but I can't find a way to do it☹️
I copied the approach from
babel-plugin-graphql-tag