Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect seat api response on POST successes #710

Closed
jgrancell opened this issue Nov 8, 2020 · 2 comments · Fixed by eveseat/api#53
Closed

Incorrect seat api response on POST successes #710

jgrancell opened this issue Nov 8, 2020 · 2 comments · Fixed by eveseat/api#53
Labels
bug complexity/low This task has a low complexity level good first issue Good for newcomers packages/api Stuff related to SeAT API

Comments

@jgrancell
Copy link

  • Problem: /api/v2/roles endpoint returns undocumented 201 error code on success.
  • Expected: 200, per Swagger documentation
  • Logs / Screenshots / Proof: https://imgur.com/wRwG9rr.png
  • Version Info: Not really relevant. PHP 7.4, Alpine container on Kubernetes.

I believe this is a documentation issue with the Swagger documentation, as Laravel returns a 201 when a new Resource is created by default.

I can submit a PR to fix this if needed.

@warlof
Copy link
Member

warlof commented Nov 8, 2020

Hi,

Indead, seems to be a typo in the swagger documentation block.

Pull requests are always welcome 😊

@warlof warlof added bug packages/api Stuff related to SeAT API complexity/low This task has a low complexity level good first issue Good for newcomers labels Nov 8, 2020
@jgrancell
Copy link
Author

PR submitted with fix for this specific response code. I'm working on building a Terraform provider for Seat, so i'll be touching every endpoint and can validate all of them over the next week.

We can keep that PR open to catch-all any other Swagger documentation fixes, or merge to close this. Doesn't matter to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug complexity/low This task has a low complexity level good first issue Good for newcomers packages/api Stuff related to SeAT API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants