Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Make SSO login URL and Image Server URL really configurable #815

Open
copyliu opened this issue Jun 6, 2021 · 1 comment · May be fixed by eveseat/services#155
Open

[Feature Request] Make SSO login URL and Image Server URL really configurable #815

copyliu opened this issue Jun 6, 2021 · 1 comment · May be fixed by eveseat/services#155
Labels
bug complexity/low This task has a low complexity level core/auth Issues related to authentication flow good first issue Good for newcomers

Comments

@copyliu
Copy link

copyliu commented Jun 6, 2021

as #800 (comment)

Everything else should be configurable in the .env file

hard-coded URL was find in
https://github.com/eveseat/services/blob/master/src/Socialite/EveOnline/Provider.php#L60
https://github.com/eveseat/eveapi/blob/master/src/Commands/Seat/Tokens/Upgrade.php#L73
https://github.com/eveseat/eseye/blob/master/tests/Fetchers/GuzzleFetcherTest.php#L221

For a Serenity instance, it's good to make them configurable via .env file EVE_SSO_HOST

also hard-coded URL
https://github.com/eveseat/services/blob/master/src/Image/Eve.php#L72
it's good to make them configurable too
@tehraven
Copy link

@copyliu this is actually fairly easy to accomplish! You should make the pull requests for this and make the mod team's life easy here.

You can see default / existing env configs defined here: https://github.com/eveseat/eveapi/blob/79698f36714d8ac4d4587b1cee2ed84a90c4701a/src/Config/esi.php#L42

And you can pull that into your code with:

config('esi.eseye_sso_port')

:)

@warlof warlof added bug good first issue Good for newcomers complexity/low This task has a low complexity level core/auth Issues related to authentication flow labels Aug 19, 2022
warlof added a commit to warlof/eveseat-services that referenced this issue Aug 19, 2022
@warlof
fix: ensure authentication server use config
8319ead 
Closes eveseat/seat#815
@warlof warlof linked a pull request Aug 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug complexity/low This task has a low complexity level core/auth Issues related to authentication flow good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure authentication server use config warlof/eveseat-services
3 participants
@tehraven @warlof @copyliu