From c8e4b13eb99bdf02482e6d4bfb4f44a551320162 Mon Sep 17 00:00:00 2001
From: Edwin Kofler <edwin@kofler.dev>
Date: Mon, 2 Oct 2023 03:42:33 -0700
Subject: [PATCH] fix: do not enable export when sourcing rc file (#553)

---
 docs/configuration.md        | 15 ++++++++++++---
 internal/templates/hook.tmpl |  3 +--
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/docs/configuration.md b/docs/configuration.md
index 07b1e464..db2e5c32 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -243,7 +243,7 @@ pre-commit:
       run: npm run eslint {staged_files}
 ```
 
-Provide a tweak to access `npm` executable the same way you do it in your ~/<shell>rc
+Provide a tweak to access `npm` executable the same way you do it in your ~/<shell>rc.
 
 ```yml
 # lefthook-local.yml
@@ -254,16 +254,25 @@ Provide a tweak to access `npm` executable the same way you do it in your ~/<she
 rc: ~/.lefthookrc
 ```
 
+Or
+
+```yml
+# lefthook-local.yml
+
+# If the path contains spaces, you need to quote it.
+rc: '"${XDG_CONFIG_HOME:-$HOME/.config}/lefthookrc"'
+```
+
+In the rc file, export any new environment variables or modify existing ones.
+
 ```bash
 # ~/.lefthookrc
 
 # An nvm way
-
 export NVM_DIR="$HOME/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
 
 # Or maybe just
-
 PATH=$PATH:$HOME/.nvm/versions/node/v15.14.0/bin
 ```
 
diff --git a/internal/templates/hook.tmpl b/internal/templates/hook.tmpl
index a815a3f1..5c79da1c 100644
--- a/internal/templates/hook.tmpl
+++ b/internal/templates/hook.tmpl
@@ -5,8 +5,7 @@ if [ "$LEFTHOOK" = "0" ]; then
 fi
 
 {{- if .Rc}}
-{{/* Load rc file and export all ENV vars defined in it */}}
-set -a
+{{/* Load rc file, which may export ENV variables */}}
 [ -f {{.Rc}} ] && . {{.Rc}}
 {{- end}}