Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report about error during ${push_files} calculation #100

Closed
ai opened this issue Jan 2, 2020 · 1 comment · Fixed by #687
Closed

Report about error during ${push_files} calculation #100

ai opened this issue Jan 2, 2020 · 1 comment · Fixed by #687
Assignees
Labels
enhancement New feature or request

Comments

@ai
Copy link
Member

ai commented Jan 2, 2020

Lefhook: 0.7, 0.6.7, 0.6.3.

Config:

pre-push:
  parallel: true
  commands:
    lint:
      glob: "*.md"
      run: remark --no-stdout --frail --quiet {push_files}

I have 1 unpushed commit with README.md changes.

logux-docs on  master 
➜ g a
## master
M  README.md
M  lefthook.yml

logux-docs on  master [+] 
➜ g c 'Commit'
SYNCING lefthook.yml
SERVED HOOKS: pre-push, prepare-commit-msg
[master 7b4d2ad] Commit
 2 files changed, 3 insertions(+), 9 deletions(-)

logux-docs on  master 
➜ n lefthook run pre-push -v
Lefthook v0.7.0
RUNNING HOOKS GROUP: pre-push

Files before filters: 
 []
Files after filters: 
 []
Files after escaping: 
 []

 lint (SKIP. NO FILES FOR INSPECTING)

SUMMARY: (SKIP EMPTY)
@ai
Copy link
Member Author

ai commented Jan 2, 2020

Seems like it is DX problem. Lefthook should report about the error during push_files generation:

➜ git diff --name-only HEAD @{push} 
fatal: no upstream configured for branch 'master'

@ai ai changed the title push_files regression Report about error during ${push_files} calculation Jan 2, 2020
@Arkweid Arkweid added the enhancement New feature or request label Jan 9, 2020
@Arkweid Arkweid self-assigned this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants