-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upsize label sizing in bar/line charts #1576
Conversation
This one might be more complex than it first seems. It was a looong time ago that I wrote this code, but I seem to remember that I spent quite a long time fighting with margins and balancing font size versus spacing for long sample names. It's very common for sample names to be huge in MultiQC reports, so this needs to work in those cases. |
Any fud with shoving it in the |
Not at all - that follows my general ethos which is "sensible defaults with ability to customise". |
Testing your PR and comparing before / after, it could also be as simple as me trying to match the matplotlib font sizes to the normal interactive plot font sizes / HTML text font sizes. I'd be willing to meet you half way and set the defaults to 10, how does that sound? Also making it configurable sounds like a sensible thing to add as well. |
I'll just make it configurable - then we don't have to worry about catering to personal prefs in defaults |
Tested using https://raw.githubusercontent.com/ewels/MultiQC_TestData/master/data/custom_content/embedded_config/test_bargraph_mqc.txt With/without:
I didn't touch the js plotly stuff. That code looks a little hairy. Let me know if that's fine, and also if this config should be documented somewhere. I couldn't find an enumeration of all the possible |
Nice, thanks! If you could just add some docs about this, then good to merge.. 👍🏻 |
Wasn't sure where to put docs. Let me know if another place is better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻 Changelog too, but I can do that myself in a second..
Just upsizes some label sizing in the bar/line charts. I understand there is no optimal size for everyone. However I find 8 point font very small, and can't imagine many folks would complain with slightly bigger font sizing. Thoughts?
CHANGELOG.md
has been updated