fix(esl-toggleable): doesn't update after changing the activator #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshovchko
requested review from
ala-n,
julia-murashko,
yadamskaya,
abarmina,
Natalie-Smirnova,
fshovchko,
HenadzV and
NastaLeo
ala-n
approved these changes
May 27, 2023
fshovchko
approved these changes
May 28, 2023
Natalie-Smirnova
approved these changes
May 29, 2023
HenadzV
approved these changes
May 29, 2023
ala-n
reviewed
May 29, 2023
fshovchko
approved these changes
May 30, 2023
fshovchko
approved these changes
May 30, 2023
ala-n
reviewed
May 30, 2023
…n params.force is set
ala-n
approved these changes
May 31, 2023
julia-murashko
approved these changes
May 31, 2023
yadamskaya
approved these changes
May 31, 2023
NastaLeo
approved these changes
May 31, 2023
HenadzV
approved these changes
May 31, 2023
ala-n
force-pushed
the
main
branch
6 times, most recently
from
1f18a8a
to
6506db7
Compare
ala-n
modified the milestones:
⚡ESL: 4.11.0 Minor release,
⚡ESL: 4.12.0 Minor release,
⚡ESL: 4.13.0 Minor release
…sl into fix/toggleable-update # Conflicts: # src/modules/esl-toggleable/core/esl-toggleable.ts
…toggleable-update
|
🎉 This PR is included in version 4.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed incorrect behavior of toggleable when the activator changes in the open state.
Closes #1677