Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(esl-event-listener): block events if scroll was detected #2098

Merged
merged 6 commits into from
Jan 29, 2024
Merged

chore(esl-event-listener): block events if scroll was detected #2098

merged 6 commits into from
Jan 29, 2024

Conversation

fshovchko
Copy link
Contributor

@fshovchko fshovchko commented Dec 6, 2023 •
edited by ala-n
Loading

This feature should handle the cases when events need to be prevented from dispatching due to scroll detection.
Should be explained better in #2085
Closes: #2085

@fshovchko fshovchko marked this pull request as draft December 6, 2023 17:20
@fshovchko fshovchko requested review from a team, ala-n, abarmina and NastaLeo and removed request for a team December 6, 2023 17:21
@ala-n ala-n added not ready for merge require squash No action from PR author required. Marks that current PR will be merged with squash labels Dec 6, 2023
Base automatically changed from epic/wheel-target to main December 8, 2023 13:18
@fshovchko fshovchko changed the title chore(esl-event-listener): block events if scroll was dtected (POC) chore(esl-event-listener): block events if scroll was detected (POC) Dec 8, 2023
@fshovchko fshovchko force-pushed the chore/ignore-swipe branch 2 times, most recently from 2272d50 to e0cae8e Compare December 8, 2023 16:53
@fshovchko fshovchko self-assigned this Dec 12, 2023
@ala-n ala-n changed the base branch from main to main-beta January 18, 2024 16:50
ala-n
ala-n reviewed Jan 18, 2024
View reviewed changes
pages/src/esl-events-demo/esl-swipe-demo/esl-swipe-demo-area.ts Outdated Show resolved Hide resolved
pages/src/esl-events-demo/esl-wheel-demo/esl-wheel-demo-area.ts Outdated Show resolved Hide resolved
pages/src/esl-events-demo/log-area/log-area.ts Outdated Show resolved Hide resolved
pages/views/draft/swipe-demo.njk Outdated Show resolved Hide resolved
pages/views/draft/wheel-demo.njk Outdated Show resolved Hide resolved
src/modules/esl-utils/dom/scroll/parent.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/swipe.target.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/swipe.target.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/dom/scroll/utils.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/dom/scroll/parent.ts Outdated Show resolved Hide resolved
@fshovchko fshovchko marked this pull request as ready for review January 21, 2024 00:40
@fshovchko fshovchko added the needs review The PR is waiting for review label Jan 21, 2024
@fshovchko fshovchko requested review from a team January 21, 2024 00:40
ala-n
ala-n reviewed Jan 22, 2024
View reviewed changes
src/modules/esl-utils/dom/scroll/utils.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/dom/scroll/parent.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/dom/scroll/parent.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/wheel.target.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/swipe.target.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/swipe.target.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/targets/swipe.target.ts Outdated Show resolved Hide resolved
@fshovchko fshovchko changed the title chore(esl-event-listener): block events if scroll was detected (POC) chore(esl-event-listener): block events if scroll was detected Jan 22, 2024
@fshovchko fshovchko added enhancement Improvements and additions to code and removed require squash No action from PR author required. Marks that current PR will be merged with squash labels Jan 22, 2024
@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone Jan 22, 2024
@ala-n ala-n linked an issue Jan 22, 2024 that may be closed by this pull request
[🚀esl-event-listener]: ability to block swipe/longwheel events for scrollable content in the "middle" state #2085
Closed
@ala-n ala-n added require squash No action from PR author required. Marks that current PR will be merged with squash finalization Changes is under final review and live testing labels Jan 29, 2024
@ala-n ala-n merged commit ecc849f into main-beta Jan 29, 2024
7 checks passed
@ala-n ala-n deleted the chore/ignore-swipe branch January 29, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@ala-n
Copy link
Collaborator

ala-n commented Feb 14, 2024

🎉 This PR is included in version 5.0.0-beta.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Natalie-Smirnova Natalie-Smirnova Natalie-Smirnova approved these changes

@abarmina abarmina abarmina approved these changes

@julia-murashko julia-murashko julia-murashko approved these changes

@ala-n ala-n ala-n approved these changes

@dshovchko dshovchko dshovchko approved these changes

@NastaLeo NastaLeo Awaiting requested review from NastaLeo NastaLeo was automatically assigned from exadel-inc/esl-core-team

@yadamskaya yadamskaya Awaiting requested review from yadamskaya

Assignees

@fshovchko fshovchko

Labels
enhancement Improvements and additions to code finalization Changes is under final review and live testing needs review The PR is waiting for review released on @beta require squash No action from PR author required. Marks that current PR will be merged with squash
Projects
None yet
Milestone
⚡ESL: 4.16.0 Major release
Development

Successfully merging this pull request may close these issues.

[🚀esl-event-listener]: ability to block swipe/longwheel events for scrollable content in the "middle" state
8 participants
@fshovchko @ala-n @dshovchko @julia-murashko @yadamskaya @abarmina @Natalie-Smirnova @NastaLeo